happybara-io / WorkflowBuddy

The missing pieces of Slack Workflow Builder.
GNU Affero General Public License v3.0
28 stars 4 forks source link

Feature/handling unescaped json #39

Closed I-Dont-Remember closed 1 year ago

I-Dont-Remember commented 1 year ago

What was changed?

Our handling of JSON strings in the common use case (JSON string which has a variable rammed into it without escaping by Slack) leads to problem characters when we try to decode the JSON. This fix allows double quotes to exist in variables for workflows and still be inserted into a JSON string (like for Outgoing Webhooks step).

Why is this good for our users?

This is good because... double quotes are an incredibly common use case to support.

Attestation

Below you'll find a checklist. For each item on the list, check one option and delete the other.