happybeing / vdash

A Dashboard for Autonomi Nodes that runs in the terminal
GNU Affero General Public License v3.0
19 stars 9 forks source link

Vdash shows GETs were PUTs are expected #11

Closed willief closed 1 year ago

willief commented 2 years ago

DRAFT : When PUTing files to the local baby-fleming network I see indications in the GETs row but nothing under PUT.

happybeing commented 2 years ago

Vdash is looking for indications of PUT and GET in the logfile so what you see reflects:

  1. what I've chosen to count as PUT and GET which may be misleading
  2. when those messages are logged by sn_node

I wouldn't be surprised to find the messages I've chosen aren't ideal, but they are the best I could find. I think once the MaidSafe team have a bit more bandwidth we can discuss with them what is available in the logs and how best to use it, and whether they can improve this to make the log output (and vdash metrics) more useful.

For now let's keep an eye on things and use this issue as a placeholder until someone (ideally not me because I don't have much time for code) takes this up with the team.

Maybe @Thierry61 (who is doing similar processing with https://github.com/Thierry61/sn_node_dash) will also be interested or able to suggest improvements either to what vdash counts or the messages logged by sn_node?

willief commented 2 years ago

screenshot just cos I took one while doing a large recursive PUT

image

happybeing commented 2 years ago

Thanks. Try grep'ing all logs for "Getting chunk" (signifying GET) and "StoredNewChunk" signifying PUT and see if you are seeing any PUTs for any node. IIRC I saw what you have above once myself in a ComNet but not since. I'm not investigating these atm until MaidSafe code settles down, but it's useful to have these issues so we can work on them later.

FYI here's the code which detects GET and PUT in the logs:

https://github.com/happybeing/vdash/blob/master/src/custom/app.rs#L857

willief commented 2 years ago

Yes, I'm not expecting instant fixes for these issues, think of them as placeholders/reminders

On Tue, 15 Mar 2022, 17:46 happybeing, @.***> wrote:

Thanks. Try grep'ing all logs for "Getting chunk" (signifying GET) and "StoredNewChunk" signifying PUT and see if you are seeing any PUTs for any node. IIRC I saw what you have above once myself in a ComNet but not since. I'm not investigating these atm until MaidSafe code settles down, but it's useful to have these issues so we can work on them later.

FYI here's the code which detects GET and PUT in the logs:

https://github.com/happybeing/vdash/blob/master/src/custom/app.rs#L857

— Reply to this email directly, view it on GitHub https://github.com/happybeing/vdash/issues/11#issuecomment-1068273558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHW3IV4DRROIN4N4YQFU3VADEF3ANCNFSM5QZCJGDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Thierry61 commented 2 years ago

FWIW I'm also looking for "Getting chunk" and "StoredNewChunk" in sn_node_dash and I get both many Gets and many Puts during a recursive safe files put command.

@happybeing, what's is interesting in the code you referenced is that you also detect "Editing Register success!" which I didn't. I will do the same and integrate them as "Edits".