happybeing / vdash

A Dashboard for Autonomi Nodes that runs in the terminal
GNU Affero General Public License v3.0
19 stars 9 forks source link

Fix incorrect latest entry time for saved checkpoints #23

Closed RMcTn closed 3 months ago

RMcTn commented 6 months ago

Checkpoints were being saved with the monitor's latest checkpoint time, but with up to date metrics. Log lines that were already accounted for in the metrics could be processed again.

Fixes #22

happybeing commented 6 months ago

Thanks very much for this. I will take a look as soon as I can but I'm not sure when that will be due to current work and something that has cropped up that may take me away from code quite a bit.

BTW would you like a mention on the forum about this when it merges, and if so do you have a forum handle?

I'm really happy that you've done this! 🙏

RMcTn commented 6 months ago

No problem at all, and don't worry about a forum mention 👍 Just happy to help

happybeing commented 3 months ago

Sorry to have taken so long to review and thank you very much for this and your other PR (also merged). I didn't realise they were one-line changes and have been so focused on another project I didn't even look :man_facepalming: