search

happycodelucky / rocket-nuimo-node

Nuimo Control device discovery, connection manager, and interface control for Node.js
MIT License
12 stars 4 forks source link

fix gatt profile and typo in onTouch event handler #1

Closed Mitch90 closed 4 years ago

Mitch90 commented 4 years ago

Hello @pryomoax, first of all thank you very much for working on this library, it was incredibly helpful.

While I was testing it with my Nuimo, I noticed that my swipes from top to bottom and from bottom to top were inverted and that when touching the bottom the log would give me a touchTop event.

Digging a little deeper I found that some bytes matchings in the gatt profile where inverted (comparing also with this resource), and also that there was a typo in an emit function.

Thanks again for you hard work!

happycodelucky commented 4 years ago

Hey @Mitch90, good catch. I guess I didn't test those in my experiments. Thanks for the PR. It looks good, I'll merge it and publish a new release shortly.

happycodelucky commented 4 years ago

v0.4.2 has been published. Thanks again!

Mitch90 commented 4 years ago

v0.4.2 has been published. Thanks again!

No, thank you!