search

happycodelucky / rocket-nuimo-node

Nuimo Control device discovery, connection manager, and interface control for Node.js
MIT License
12 stars 4 forks source link

Missing package-lock.json #11

Closed riker09 closed 3 years ago

riker09 commented 3 years ago

Is there any particular reason, why there is no package-lock.json committed to this repo? I believe it is good practise to provider other developers with that file. They will get the same packages you installed during development, while later versions occacionally break stuff.

happycodelucky commented 3 years ago

Ah, I use yarn so there’s a yarn.lock. npm 7 now supports yarn’s lock files

happycodelucky commented 3 years ago

Any reason you need package-lock.JSON in this repo? The published package on npmjs.org is always built and publish with yarn

riker09 commented 3 years ago

No. I was just curious. Guess I should use this as an excuse to update to npm v7 then. :)