search

happycube / ld-decode

Software defined LaserDisc decoder
GNU General Public License v3.0
307 stars 80 forks source link

Add OS information into logs/debug output for ld-decode-tools and ld-decode #782

Open simoninns opened 2 years ago

simoninns commented 2 years ago

Since there are many users running in unsupported environments it is getting really hard to tell if issue reports are really issues at all. The ld-decode tools (and probably ld-decode) should report the underlying OS and version in all debug so if bugs are reported on unsupported systems they can be pushed to the port maintainer for first-pass analysis.

happycube commented 2 years ago

This turns out to be a pretty easy change using the platform library. The output for Linux isn't as good as using /etc/lsb-release, but it should always work.

happycube commented 2 years ago

Done, at least for the json file. missed the debug logs.

simoninns commented 2 years ago

I need to modify the tools output too... So note when ld-decode is done and I'll update when ld-decode-tool match... then we can close.

harrypm commented 10 months ago

It would be good if this also stores inital command used for decoding aswell so user error can be easily catched/pointed out.