happycube / ld-decode

Software defined LaserDisc decoder
GNU General Public License v3.0
294 stars 76 forks source link

--threads option not working #866

Closed ArcadeHacker closed 8 months ago

ArcadeHacker commented 9 months ago

Hi there, i'm unable to get --threads to work as intended on a high count core machine, no matter what I do I cannot get ld-decode to run more than aprox. 6 threads. Tested on a computer with 36 threads, other tools such as sysbench show proper behavior on the same computer (eg use all available threads). Tested on Ubuntu 22.04.3 (intel).

Thanks.

happycube commented 9 months ago

The TBC is a bottleneck at that point, so the worker threads that do the RF decoding have nothing to do.

harrypm commented 9 months ago

@ArcadeHacker Its all single core bais speed wise, so no more then 4-6 threads will improve anything across the formats though speed testing is tracked here curreent gen hardware can decode some formats upto 16fps+

happycube commented 8 months ago

It'd be nice to improve this (it's better than it was) but improving this is a side effect of TBC optimization/threading, closing.