search

happydasch / btoandav20

Support for Oanda-V20 API in backtrader
Apache License 2.0
131 stars 52 forks source link

Not consistence parameter stoploss & pips name in getsizing function #64

Closed santatic closed 3 years ago

santatic commented 3 years ago

I have run btoandav20 backtest and realtime testing. On backtesting, I used class OandaV20BacktestRiskPercentSizer for sizing And on realtime, I used class OandaV20RiskPercentSizer for sizing

Then I get a error when call function getsizing with parameter pips is not found in function OandaV20RiskPercentSizer.getsizing, because OandaV20RiskPercentSizer.getsizing called it is stoploss

Is it a in-consistence update, or we use it for any other intention?

happydasch commented 3 years ago

Hi, you are right. I did some changes lately to the backtest sizers and did not update the sizer var naming. will update the sizer to also use pips. Thanks for posting the issue.