search

happydata / nomielab

DEAD Project from Nomie 1 days - No longer maintained
https://nomie.app
MIT License
29 stars 2 forks source link

Fix dropbox import & update Leaflet CDN #3

Closed duncancarroll closed 6 years ago

duncancarroll commented 6 years ago

Looks like at some point the key for the Events array got changed from ticks to events, which causes no events to be imported. This PR fixes this issue by updating the key to the new value. It does not attempt to be backwards-compatible however.

brandoncorbin commented 6 years ago

Oh my lawd, I haven't thought about the lab in a long time - have you used been using it?

duncancarroll commented 6 years ago

Haha, I thought I'd dust it off and give it a spin. It still works pretty well! Not bad for an old codebase! I'm not much of a JS engineer or I'd be happy to do more. It seems like a good interface to build on; nice work!

Duncan

On Mon, May 14, 2018, 6:21 PM Brandon Corbin notifications@github.com wrote:

Oh my lawd, I haven't thought about the lab in a long time - have you used been using it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/happydata/nomielab/pull/3#issuecomment-389012220, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxnABloB3Dc2zsRy1fs0YABzdsHOZA_ks5tyi2jgaJpZM4T8h5Q .