search

happyfoxinc / helpstack

iOS Support Framework
http://helpstack.io
MIT License
475 stars 69 forks source link

Fix 'HelpStackStoryboard' not found crash #65

Open mithiljadhav opened 7 years ago

mithiljadhav commented 7 years ago

Environment: Xcode 8, Swift 3, Cocoapods podfile with "use_frameworks!"

When using use_frameworks in podfile, the "HelpStackStoryboard" is not found since it is created using main bundle. This results in a crash when showing help.

Replacing [NSBundle mainBundle] with [NSBundle bundleForClass:self.classForCoder] resolves this issue

tomreay commented 7 years ago

Are there plans to merge this and release? At the moment we can't use helpstack because of it

francisjervis commented 7 years ago

With these changes, I still get the crash on xCode 9 beta 4.