search

happyharrycn / actionformer_release

Code release for ActionFormer (ECCV 2022)
MIT License
415 stars 77 forks source link

Regarding NMS #121

Closed Moadab-AI closed 10 months ago

Moadab-AI commented 11 months ago

Hi,

Just wondering is there any particular reason you are not using torchvision's built-in nms (https://pytorch.org/vision/main/generated/torchvision.ops.nms.html#torchvision.ops.nms) simply by passing a (onset, 0, offset, 1) as bbox coordinates instead of all this cpp implementation?

tzzcl commented 11 months ago

You can choose torchvision's nms for your convenience.

happyharrycn commented 10 months ago

NMS in torchvision is designed for 2D cases and does not support soft NMS. That is why we implemented a cpp version.