search

happyjack27 / autoredistrict

Programmatically makes a fair congressional district map (prevents gerrymandering)
GNU General Public License v3.0
89 stars 15 forks source link

Replace Apache Commons Math3 with Maven dependency #222

Closed Noreaster76 closed 1 year ago

Noreaster76 commented 1 year ago

Replace the copied-in code for the org.apache.commons.commons-math3 library with that of a Maven dependency (of the same library).

Benefits:

Obviously, the org.apache.commons.commons-math3 code is always available on Apache's repo to look at, if desired.

happyjack27 commented 1 year ago

I think I might have copied in the code so that I could do some custom modifications, to do some bayesian probability distributions, for the "advanced stats". I'll have to check.

On Tue, Nov 14, 2023, 9:09 PM Gabe Heafitz @.***> wrote:

Replace the copied-in code for the org.apache.commons.commons-math3 library with that of a Maven dependency (of the same library).

Benefits:

  • Less code in the codebase that needs to be maintained.
  • Less code for a newcomer to get acquainted with.
  • Much easier to incorporate any updates to the org.apache.commons.commons-math3 library -- it's a simple matter of updating the version in the Maven POM (assuming no breaking changes, of course).

Obviously, the org.apache.commons.commons-math3 code is always available on Apache's repo to look at, if desired.

You can view, comment on, or merge this pull request online at:

https://github.com/happyjack27/autoredistrict/pull/222 Commit Summary

File Changes

(300 files https://github.com/happyjack27/autoredistrict/pull/222/files)

happyjack27 commented 1 year ago

Ah, I see you extended the classes I modified and put my new / modified code in the extended class. I was thinking the same thing. Looks good.