search

happykit / flags

⛳️ Feature Flags for Next.js
https://happykit.dev
MIT License
1.01k stars 11 forks source link

getFlags function has TS issue #44

Open unoscar opened 1 year ago

unoscar commented 1 year ago

Hi there, I am using the flags implementation into a next.js project with TS, when creating the getFlags function I get the following error:

Exported variable 'getFlags' has or is using name 'FactoryGetFlagsOptions' from external module "/home/unoscar/workspace/src/github.com/bd-dashboard/main-platform/node_modules/@happykit/flags/dist/server" but cannot be named.ts(4023)

I believe this can get fixed by just exporting the FactoryGetFlagsOptions interface.

I'll be creating a fork with the fix and a PR, but in case it help to have the issue recorded here. Cheers

dferber90 commented 1 year ago

Interesting, as I've not seen that before.

How are you importing getFlags in your code? Could you copy the import line here?

Are you maybe importing from @happykit/flags/dist/server instead of @happykit/flags/server?

karmatradeDev commented 1 year ago

hi im having this problem as well i think an export on line 18 does the trick.

Screenshot 2023-04-17 at 11 52 01 AM
dferber90 commented 1 year ago

@karmatradeDev Could you show the source code of the file where you are seeing this error?