search

happyleavesaoc / aoc-mgz

Age of Empires II recorded game parsing and summarization in Python 3.
MIT License
197 stars 42 forks source link

Fix some python3 compile errors #50

Closed nymanjens closed 3 years ago

happyleavesaoc commented 3 years ago

Could we do player_id, formation_id, *object_ids = ... instead of player_id, formation_id, (*object_ids,) = ...?

nymanjens commented 3 years ago

Done

happyleavesaoc commented 3 years ago

Thanks!

JacobALundgren commented 3 years ago

Just to double-check, is there a particular reason why https://github.com/happyleavesaoc/aoc-mgz/blob/master/mgz/fast/header.py#L108 was left in place? I seem to be getting the "can't use starred expression here" from this still, but maybe I'm just doing something wrong? Will gladly put in a PR for that otherwise!

nymanjens commented 3 years ago

I just fixed whatever needed to get it work on my machine.