Reliability fixes for v6 bridge

happyleavesaoc / python-limitlessled

MIT License

33 stars 22 forks source link

Reliability fixes for v6 bridge #39

Closed amelchio closed 5 years ago

amelchio commented 5 years ago

This reverts the last part of #37. It has caused several issues (reported in home-assistant/home-assistant#15844) including:

The bridge sometimes drops messages when new commands are sent right after an ACK.
The timing in the colorloop is broken.

I do not have the time to properly fix this so I thought it better to do a revert for now.

Also included is a commit that catches more socket exceptions in the keep-alive thread and thus makes it reconnect after the bridge has been unavailable.

soldag commented 5 years ago

I tested this on v6 bridge and it works fine.

@happyleavesaoc Anything against merging this? I would love to see these fixes in home-assistant.

amelchio commented 5 years ago

@happyleavesaoc What do you think about this?

happyleavesaoc commented 5 years ago

Can't get github to merge this ... just getting a generic error. I'll do it by diff if have to, I guess.