search

happyleavesaoc / python-limitlessled

MIT License
33 stars 22 forks source link

Support for RGB (not RGBW) lights? #6

Open davidmonro opened 7 years ago

davidmonro commented 7 years ago

Hi,

I note the library doesn't appear to currently support RGB lights. Although limitless stopped selling the plain RGB ones a while ago there are other people currently making things which are compatible with them - like pool lights (http://www.davey.com.au/products/pool-lights/pal-4000-series-led-lights-with-remote-control.html)

The RGB commands are documented under "LimitlessLED RGB CommandSet " on http://www.limitlessled.com/dev/ . The main problem I can see is that there's no concept of a group with the RGB ones, so I'm not sure how to integrate it into the existing paradigm - perhaps only allow creation of group '1' of type RGB?

ReDetection commented 5 years ago

I was able to adapt on and off commands by simply replacing 0x45 and 0x46 in the source code with 0x22 and 0x21. There is JS implementation which actually works better with this legacy kind of bulbs, you can use it as a command reference https://github.com/mwittig/node-milight-promise/blob/6ed3b4fcd31857a60ec55c4ffd554823c32a50d5/src/commands.js#L166-L178