search

happyleavesaoc / python-limitlessled

MIT License
33 stars 22 forks source link

Support for LimitlessLED Wifi Bridge v6.0 #7

Closed alexmat closed 7 years ago

alexmat commented 7 years ago

Is it possible to add support for the new wifi bridges? I just bought one and would like to use it with this library. The specs have been published here: http://www.limitlessled.com/dev/

ash-vd commented 7 years ago

The "problem" I believe there still is, is that the transitions are slow because of the mixing of commands. I think this could be fixed in a next release, but I don't know how you guys think about that. On the other side: might be a better idea to smash any know bugs now instead of after merging.

JohanLeirnes commented 7 years ago

I agree with ashen, better crush the bugs before merge.

durzo commented 7 years ago

I'd like to suggest merging now and fixing any bugs later simply because the current state of home-assistant does not work at all with v6. surely a mostly-working product is better than a totally broken one?

for whats it worth, my transitions are perfectly fine with no delay, but meh...

soldag commented 7 years ago

I finally managed to fix the remaining transition issue and created a PR. 🎉

happyleavesaoc commented 7 years ago

I'll test and merge soon.

happyleavesaoc commented 7 years ago

Merged in #9. Thanks @soldag!

RiRomain commented 7 years ago

@soldag will you also open a merge request on hass? Or should someone else do it?

Just as reference, all those issues can be close after it's merged in home-assistant: https://github.com/home-assistant/home-assistant/issues/4941 https://github.com/home-assistant/home-assistant/issues/4676 https://github.com/home-assistant/home-assistant/issues/4672

MMaximuss commented 7 years ago

Great, much respect for you guys, especially Soldag and Happyleavesaoc. If I want to update this module manually in my HA-installation, how do I manage that?

soldag commented 7 years ago

@RiRomain https://github.com/home-assistant/home-assistant/pull/5958

RiRomain commented 7 years ago

Awesome, thanks for the great work on this :-)