search

happyleavesaoc / python-limitlessled

MIT License
33 stars 22 forks source link

Support for bridge v6 and RGBWW bulbs #9

Closed soldag closed 7 years ago

soldag commented 7 years ago

As already discussed in #7, this adds support for wifi bridges v6 and RGBWW bulbs. While implementing I also faced some minor issues (especially with the transition logic), which I fixed in general for all bulb types. I could only test with bridge v6 and RGBWW bulbs, so I cannot guarantee that it works for older bridges or other led types. Therefore, to ensure I didn't break anything, somebody else has to test this. There were also some guys which confirmed that this fork is working in #7 ;)

happyleavesaoc commented 7 years ago 
  File "/envs/hass/lib/python3.5/site-packages/limitlessled/bridge.py", line 182, in _consume
    self._send_raw(command.select_command)
  File "/envs/hass/lib/python3.5/site-packages/limitlessled/bridge.py", line 195, in _send_raw
    self._socket.send(bytearray(command))
TypeError: 'Command' object is not iterable

After trying to set brightness on a legacy white bulb.

Btw, the legacy RGBW works great now with the latest commits.

soldag commented 7 years ago

Good to hear that the RGBW bulbs work now :) I made a fix for the issue you mentioned.

happyleavesaoc commented 7 years ago

That change prevents the error, but the brightness and temperature don't work. I will do some debugging when I get a chance, hopefully tomorrow.

soldag commented 7 years ago

I pushed a commit, which should fix this issue.

happyleavesaoc commented 7 years ago

Indeed it does. Awesome!

Merged.