search

happymimimix / midi2flp-CPP

C++ port of the python midi to flp converter by SatyrDiamond.
1 stars 1 forks source link

Bug #1

Closed lt1089-Coder closed 2 hours ago

lt1089-Coder commented 3 hours ago

The software will exit the program when opening a MIDI file with a width of 256.

happymimimix commented 3 hours ago

You mean 256 keys?

happymimimix commented 3 hours ago

image I replicated that successfully with the 256 keys mod of domino. This is the problem of the midi parsing library I'm using. MIDIfiles.h is not expecting any value to be greater than 0x7F in the midi file. It would throw an error if it detected events with value greater than 0x7F. This should be easy to resolve, just remove the if statements that does this detection in the library. My code should not have any issue at handling 256k midis in theory.

happymimimix commented 2 hours ago

Result: image image

happymimimix commented 2 hours ago

https://github.com/happymimimix/midi2flp-CPP/releases/tag/002