search

happypandax / plugins

Plugins for HappyPanda X
https://happypandax.github.io/
GNU Lesser General Public License v3.0
32 stars 16 forks source link

Added tags to the title for common failure conditions #50

Open glop102 opened 1 year ago

glop102 commented 1 year ago

There are two common failure modes for e(x)hentai galleries 1) the gallery is expunged (eg copyright takedown) 2) the user is out of GP to download the archive Failure 2 is easily detectable as the response to getting the archive URL specifically reports such a failure. Failure 1 is more of an educated guess as the point of detection is getting a 404 even though we were given an archive key.

Also a seemingly innocuous bug of the condition of which login service to use. The condition to choose x or non-x was backwards.

glop102 commented 1 year ago

Uhhh, whoops, i just realized i screwed up a little bit. The way i am detecting if a gallery is expunged is with assuming that is what happened when we get a 404 when trying to grab that archive. There is a very straight forward and obvious field "expunged" of true/false that is handed to us instead of just assuming things later on that should be used instead. I will make that change to do things correctly tomorrow.

glop102 commented 1 year ago

Well i gave up on using the "expunged" flag because it is nonsensical for when it is true or false. I also cleaned up the downloader plugin a bit for readability.