search

happypoulp / redux-tutorial

Learn how to use redux step by step
3.76k stars 546 forks source link

syncs timeout and log of state in final example with the rest of the … #67

Closed joeshub closed 8 years ago

joeshub commented 8 years ago

Your tutorial helped me so much thank you!

Found it useful to see the same state/action log in 12 as you had in the rest of the tutorial, also the 2 second delay matching steps 8 and 9 might be good to illustrate the async actions.

happypoulp commented 8 years ago

I'd be glad to merge your fixes but I am a bit reluctant to force a 2 seconds delay on the example. I understand your point but it would not send a "positive message" to take 2 seconds to display the current time ;). I will however update the timeout to 500ms (to make it more obvious that some fake async task is going on) with a clear message that this time can be adjusted in https://github.com/happypoulp/redux-tutorial/blob/master/12_src/src/home.jsx.

happypoulp commented 8 years ago

Done in 7e91ecfd63933aa41f49d558a721beac2eda146f . Thanks for your fixes!