haproxytech / helm-charts

Helm chart for HAProxy Kubernetes Ingress Controller
Apache License 2.0
155 stars 121 forks source link

It would be interesting to be able to introduce additional metadata labels in the deployments and statefulsets #250

Open gustavoborragan opened 4 months ago

gustavoborragan commented 4 months ago

It would be interesting to be able to introduce additional metadata labels in the deployments and statefulsets.

Current deployment:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    ...
  labels:
    app.kubernetes.io/instance: haproxy
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: haproxy
    app.kubernetes.io/version: 2.8.1
    helm.sh/chart: haproxy-1.19.2

With deploymentLabels key into values:

deploymentLabels:
  foo: bar
  bar: foo

Desired deployments:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    ...
  labels:
    app.kubernetes.io/instance: haproxy
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: haproxy
    app.kubernetes.io/version: 2.8.1
    bar: foo
    foo: bar
    helm.sh/chart: haproxy-1.19.2
dkorunic commented 4 months ago

Hi @gustavoborragan , any specific use-case that you had in mind for this?

gustavoborragan commented 4 months ago

Hi @dkorunic, yes, for example, adding metadata for observation applications.

gustavoborragan commented 2 months ago

Hello dear ones. Any news on this? Thanks!!!

dkorunic commented 2 months ago

Hi @gustavoborragan, no progress on this yet, but it's in the pipeline to be added.