search

haproxytech / kubernetes-ingress

HAProxy Kubernetes Ingress Controller
https://www.haproxy.com/documentation/kubernetes/
Apache License 2.0
712 stars 200 forks source link

Missing master socket option #493

Open dosmanak opened 1 year ago

dosmanak commented 1 year ago

https://github.com/haproxytech/kubernetes-ingress/blob/2a8b907ac610b959e0c056dd90418b205169964a/fs/etc/services.d/haproxy/run#L20

should create master socket for debugging purposes https://cbonte.github.io/haproxy-dconv/2.6/management.html#9.4

ivanmatmati commented 1 year ago

Hi @dosmanak , I will submit your idea to the team. Thanks for suggesting.

hdurand0710 commented 1 year ago

Hi @dosmanak ,

The change has been included in commit.

It will be included in the next release. Best regards

dosmanak commented 1 year ago

Hello @hdurand0710 that is great. I already forgot this issue. The commit seems to cover more than just master socket. Thank you. When the commit is released, feel free to close the issue. Though it is a pitty the commit message strategy does not include the issue id for back reference.