search

haproxytech / kubernetes-ingress

HAProxy Kubernetes Ingress Controller
https://www.haproxy.com/documentation/kubernetes/
Apache License 2.0
690 stars 196 forks source link

Try to understand the mode for tcpcr in 3.0.0 #658

Open cxfcxf opened 3 weeks ago

cxfcxf commented 3 weeks ago

https://github.com/haproxytech/kubernetes-ingress/blob/master/pkg/handler/tcp-cr.go#L139 in this code, it forces the frontend to have mode tcp

but in the TCP CR doc here

it is said to allow mode http or tcp in CRD. i am confused here, is that http for something else or its just not implanted?

hdurand0710 commented 3 weeks ago

@cxfcxf , You are right. We will update the documentation accordingly. You can use all fields of a client native Frontend model, expect the mode that is forced to tcp. The documentation here was auto generated from the Backend model, we should explain that mode is not used and if used would we forced to tcp.

cxfcxf commented 3 weeks ago

thanks, i m also wondering if there is a plan to support more bind params in http/https handler?

we try to split thread for http and https works, but it seems its not supported.

cxfcxf commented 2 weeks ago

so i sent a PR for the supporting thread pin on http https and healthz which can be helpful for people runnign it as external mode

https://github.com/haproxytech/kubernetes-ingress/pull/661