haproxytech / spoa-mirror

Mirror HTTP requests using the HAProxy SPOP
GNU Lesser General Public License v2.1
40 stars 16 forks source link

spoa-mirror failing to properly forward a Post when it encounters a header without a value #10

Closed mark-k-english closed 4 years ago

mark-k-english commented 4 years ago

Several indications that the message was properly processed exist but when I look at debugging output it shows all headers being processed when i eliminate the header with the missing value. In the output below the bad header is passphrase.

Does not work properly end to end example debugging:

[ 1][ 72.999218] <1> mirror[3] name='arg_hdrs' type=9: <.content-length.249551.psp_qpassword.password.psp_instance.dev100023.psp_quser.qa/qa.psp_input_queue.psp.out.replicator.ivantest.passphrase..content-type.text/json.x-snc-integration-source 75157ea6db3644502f68c59705961924.user-agent.Jakarta Commons-HttpClient/3.1.host(us-east-2-pspprod-proxy2.perspectium.net..>

[ 1][ 72.999293] <1> str[10]: ** This is the header with no value!

Does work properly:

[ 2][ 4031.637834] <2> mirror[3] name='arg_hdrs' type=9: <> <.content-length.249551.psp_qpassword.password.psp_instance.dev100023.psp_quser.qa/qa.psp_input_queue.psp.out.replicator.ivantest.passphrase.abc123.content-type.text/json.x-snc-integration-source 75157ea6db3644502f68c59705961924.user-agent.Jakarta Commons-HttpClient/3.1.host(us-east-2-pspprod-proxy2.abc.net..>

[ 2][ 4031.643867] <2> str[17]: <Jakarta Commons-HttpClient/3.1>

zaga00 commented 4 years ago

Hello @mark-k-english,

what version of the program are you using? Commit 69a52d9 fixes similar (or the same) bug.

There is something strange about displaying this issue because it lacks the content of individual lines. In the mail I received these lines are complete, they are not here.

mark-k-english commented 4 years ago

Thanks for the fast response!

I'm running spoa-mirror v1.2.1 [build 2309] by Miroslav Zagorac < mzagorac@haproxy.com>, Dec 16 2019

I'll upgrade, test again and let you know. Thanks - ME

On Thu, Mar 5, 2020 at 12:51 PM Miroslav Zagorac notifications@github.com wrote:

Hello @mark-k-english https://github.com/mark-k-english,

what version of the program are you using? Commit 69a52d9 https://github.com/haproxytech/spoa-mirror/commit/69a52d9f7cca4242a0a563a4d754542d2ad9e9ba fixes similar (or the same) bug.

There is something strange about displaying this issue because it lacks the content of individual lines. In the mail I received these lines are complete, they are not here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/haproxytech/spoa-mirror/issues/10?email_source=notifications&email_token=AHZ5ACZMMGB7RGV7ZIROOELRGAGD7A5CNFSM4LCQC572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN63FUI#issuecomment-595440337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZ5AC6UDXFAW5JVWMOIO4DRGAGD7ANCNFSM4LCQC57Q .

mark-k-english commented 4 years ago

Hi,

Sorry about not making sure I was using the latest version before creating an issue. The current version solves my problem, thanks much! ME

On Thu, Mar 5, 2020 at 12:51 PM Miroslav Zagorac notifications@github.com wrote:

Hello @mark-k-english https://github.com/mark-k-english,

what version of the program are you using? Commit 69a52d9 https://github.com/haproxytech/spoa-mirror/commit/69a52d9f7cca4242a0a563a4d754542d2ad9e9ba fixes similar (or the same) bug.

There is something strange about displaying this issue because it lacks the content of individual lines. In the mail I received these lines are complete, they are not here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/haproxytech/spoa-mirror/issues/10?email_source=notifications&email_token=AHZ5ACZMMGB7RGV7ZIROOELRGAGD7A5CNFSM4LCQC572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN63FUI#issuecomment-595440337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZ5AC6UDXFAW5JVWMOIO4DRGAGD7ANCNFSM4LCQC57Q .

zaga00 commented 4 years ago

No problem. Thank you for reporting.