search

haraka / Haraka

A fast, highly extensible, and event driven SMTP server
https://haraka.github.io
MIT License
5.09k stars 661 forks source link

2.7.1 plugin loading broken #1270

Closed msimerson closed 8 years ago

msimerson commented 8 years ago

@Synchro and I just ran into this:

loglevel: LOGINFO
Starting up Haraka version 2.7.1
[INFO] [-] [core] Loading plugins
[INFO] [-] [core] Loading plugin: process_title
[CRIT] [-] [core] Compiling plugin: process_title failed
[CRIT] [-] [core] Error: Cannot find module 'process_title'
[CRIT] [-] [core]     at Function.Module._resolveFilename (module.js:336:15)
[CRIT] [-] [core]     at Function.Module._load (module.js:286:25)
[CRIT] [-] [core]     at Module.require (module.js:365:17)
[CRIT] [-] [core]     at require (module.js:384:17)
[CRIT] [-] [core]     at /usr/local/lib/node_modules/Haraka/plugins.js:398:23
[CRIT] [-] [core]     at /usr/local/haraka/plugins/process_title/package.json:1:9
[CRIT] [-] [core]     at ContextifyScript.Script.runInNewContext (vm.js:18:15)
[CRIT] [-] [core]     at Object.exports.runInNewContext (vm.js:49:17)
[CRIT] [-] [core]     at Object.plugins._load_and_compile_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:236:12)
[CRIT] [-] [core]     at Object.plugins.load_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:172:26)
[NOTICE] [-] [core] Shutting down

Reverting this commit works for both of us to get 2.7.1 working.

msimerson commented 8 years ago

PR #1242

baudehlo commented 8 years ago

Damn. That may be something that also broke what @smfreegard was talking to me about.

Let's just revert it and push 2.7.2. It has no functional improvement.

On Dec 15, 2015, at 8:14 PM, Matt Simerson notifications@github.com wrote:

@Synchro and I just ran into this:

loglevel: LOGINFO Starting up Haraka version 2.7.1 [INFO] [-] [core] Loading plugins [INFO] [-] [core] Loading plugin: process_title [CRIT] [-] [core] Compiling plugin: process_title failed [CRIT] [-] [core] Error: Cannot find module 'process_title' [CRIT] [-] [core] at Function.Module._resolveFilename (module.js:336:15) [CRIT] [-] [core] at Function.Module._load (module.js:286:25) [CRIT] [-] [core] at Module.require (module.js:365:17) [CRIT] [-] [core] at require (module.js:384:17) [CRIT] [-] [core] at /usr/local/lib/node_modules/Haraka/plugins.js:398:23 [CRIT] [-] [core] at /usr/local/haraka/plugins/process_title/package.json:1:9 [CRIT] [-] [core] at ContextifyScript.Script.runInNewContext (vm.js:18:15) [CRIT] [-] [core] at Object.exports.runInNewContext (vm.js:49:17) [CRIT] [-] [core] at Object.plugins._load_and_compile_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:236:12) [CRIT] [-] [core] at Object.plugins.load_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:172:26) [NOTICE] [-] [core] Shutting down Revering this commit work for both of us to get 2.7.1 working.

— Reply to this email directly or view it on GitHub.

msimerson commented 8 years ago

Works for me.

Matt

(I was going to try figuring out what it was supposed to later tonight.)

On Dec 15, 2015, at 5:27 PM, Matt Sergeant notifications@github.com wrote:

Damn. That may be something that also broke what @smfreegard was talking to me about.

Let's just revert it and push 2.7.2. It has no functional improvement.

On Dec 15, 2015, at 8:14 PM, Matt Simerson notifications@github.com wrote:

@Synchro and I just ran into this:

loglevel: LOGINFO Starting up Haraka version 2.7.1 [INFO] [-] [core] Loading plugins [INFO] [-] [core] Loading plugin: process_title [CRIT] [-] [core] Compiling plugin: process_title failed [CRIT] [-] [core] Error: Cannot find module 'process_title' [CRIT] [-] [core] at Function.Module._resolveFilename (module.js:336:15) [CRIT] [-] [core] at Function.Module._load (module.js:286:25) [CRIT] [-] [core] at Module.require (module.js:365:17) [CRIT] [-] [core] at require (module.js:384:17) [CRIT] [-] [core] at /usr/local/lib/node_modules/Haraka/plugins.js:398:23 [CRIT] [-] [core] at /usr/local/haraka/plugins/process_title/package.json:1:9 [CRIT] [-] [core] at ContextifyScript.Script.runInNewContext (vm.js:18:15) [CRIT] [-] [core] at Object.exports.runInNewContext (vm.js:49:17) [CRIT] [-] [core] at Object.plugins._load_and_compile_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:236:12) [CRIT] [-] [core] at Object.plugins.load_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:172:26) [NOTICE] [-] [core] Shutting down Revering this commit work for both of us to get 2.7.1 working.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

baudehlo commented 8 years ago

Just waiting for Travis to finish. I'll merge and publish etc once done.

On Tue, Dec 15, 2015 at 8:31 PM, Matt Simerson notifications@github.com wrote:

Works for me.

Matt

(I was going to try figuring out what it was supposed to later tonight.)

On Dec 15, 2015, at 5:27 PM, Matt Sergeant notifications@github.com wrote:

Damn. That may be something that also broke what @smfreegard was talking to me about.

Let's just revert it and push 2.7.2. It has no functional improvement.

On Dec 15, 2015, at 8:14 PM, Matt Simerson notifications@github.com wrote:

@Synchro and I just ran into this:

loglevel: LOGINFO Starting up Haraka version 2.7.1 [INFO] [-] [core] Loading plugins [INFO] [-] [core] Loading plugin: process_title [CRIT] [-] [core] Compiling plugin: process_title failed [CRIT] [-] [core] Error: Cannot find module 'process_title' [CRIT] [-] [core] at Function.Module._resolveFilename (module.js:336:15) [CRIT] [-] [core] at Function.Module._load (module.js:286:25) [CRIT] [-] [core] at Module.require (module.js:365:17) [CRIT] [-] [core] at require (module.js:384:17) [CRIT] [-] [core] at /usr/local/lib/node_modules/Haraka/plugins.js:398:23 [CRIT] [-] [core] at /usr/local/haraka/plugins/process_title/package.json:1:9 [CRIT] [-] [core] at ContextifyScript.Script.runInNewContext (vm.js:18:15) [CRIT] [-] [core] at Object.exports.runInNewContext (vm.js:49:17) [CRIT] [-] [core] at Object.plugins._load_and_compile_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:236:12) [CRIT] [-] [core] at Object.plugins.load_plugin (/usr/local/lib/node_modules/Haraka/plugins.js:172:26) [NOTICE] [-] [core] Shutting down Revering this commit work for both of us to get 2.7.1 working.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/haraka/Haraka/issues/1270#issuecomment-164955647.

baudehlo commented 8 years ago

Fixed. Pushed. Published. Blog updated.

Sorry!