search

haraka / Haraka

A fast, highly extensible, and event driven SMTP server
https://haraka.github.io
MIT License
5.09k stars 662 forks source link

improve name of plugins.core_require #1669

Closed msimerson closed 8 years ago

msimerson commented 8 years ago

At present, the function npm module plugins use to load Haraka plugins is core_require. The core prefix is grokked by approximately 4 humans and is otherwise meaningless to other developers.

I suggest renaming it to haraka_require.

msimerson commented 8 years ago

Especially in light of this from Plugins.md:

Plugins loaded as modules do not have this special `require()`. In order to load
a core Haraka module you will have to use `this.core_require('name')`. Note that
this should be preferred anyway for plain javascript plugins anyway, as the
`./` hack is likely to go away in the future.