search

haraka / Haraka

A fast, highly extensible, and event driven SMTP server
https://haraka.github.io
MIT License
5.05k stars 660 forks source link

Beautify NDNs #1688

Closed typingArtist closed 5 months ago

typingArtist commented 7 years ago

NDNs currently don’t contain a proper header, at least in the tests I have run (messages bounced because of rejectUnauthorized), it’s missing From, To, and Subject.

Bramzor commented 7 years ago

Proper header is indeed missing, source of mail: Return-Path: <unknown> Delivered-To: unknown To: <> Delivered-To: <>

With setting the file config/outbound.bounce_message to something useful, it already helps a bit to create a nicer looking bounce message. Creating a separate issue for adding a HTML part and the mail as attachment, as it seems the bounce itself is already multipart/report as content type.

msimerson commented 6 years ago

@Bramzor HTML additions were merged in #2091.

msimerson commented 6 years ago

Is there anything left to do here? The From, To, and Subject headers are being added, unless @typingArtist had a stale or missing config/bounce_message.

Bramzor commented 6 years ago

Tested in version 2.8.20 today and although it does not show the unknowns anymore, I'm not sure if it is the correct behavior: Bounced message headers:

Delivered-To: something@somemail.com To: <> Delivered-To: <> Return-Path: <> Subject: Delivery Status Notification (Failure)

But subject isn't missing now and although Delivered-To is duplicated (might be the receiving server doing that), To and Return-Path are empty? Is this as expected? If so, we can close this one.

baudehlo commented 6 years ago

The To is wrong. Return Path is right.

On Sun, Aug 19, 2018 at 3:20 PM Bramzor notifications@github.com wrote:

Tested in version 2.8.20 today and although it does not show the unknowns anymore, I'm not sure if it is the correct behavior: Bounced message headers:

Delivered-To: something@somemail.com To: <> Delivered-To: <> Return-Path: <> Subject: Delivery Status Notification (Failure)

But subject isn't missing now and although Delivered-To is duplicated (might be the receiving server doing that), To and Return-Path are empty? Is this as expected? If so, we can close this one.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haraka/Haraka/issues/1688#issuecomment-414149457, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobYzQG1YVSrod7TJGMvDO8ExKrY6Cnks5uSbp_gaJpZM4Kfjl4 .

msimerson commented 5 months ago

Closing as finished in #2091