search

haraka / Haraka

A fast, highly extensible, and event driven SMTP server
https://haraka.github.io
MIT License
5.06k stars 660 forks source link

"[core] [NOTICE] - recipient rcpt.format() code=DENY ..." #2228

Closed analogic closed 7 years ago

analogic commented 7 years ago

https://github.com/haraka/Haraka/blob/0c95e42015dd262cb0bee0a5d9d6699fa6fe1b42/connection.js#L1037

There is something wrong with this line in master. I am no expert in Javascript nor understand why template literars are not working as supposed to.

msimerson commented 7 years ago

Help us help you. Create a new ticket, and this time, instead of deleting all the extra information we ask for in new issues, include it.

analogic commented 7 years ago

Sorry. I've found issue now, it does only when rcpt_to list is empty (by my own faulty filtering) and thus rcpt is undef/null, but its strange behaviour of js to evaluate literars like that...

msimerson commented 7 years ago

its strange behaviour of js to evaluate literars like that

I wondered if it peculiar to your version of node.js. 🤷‍♂️

baudehlo commented 7 years ago

The rcpt_ok_respond hook assumes there is at least one rcpt_to in transaction.rcpt_to, because you just OK'd it.

We could probably put some belt and braces around that, but it's not a HUGE deal.

On Thu, Oct 19, 2017 at 3:15 PM, Matt Simerson notifications@github.com wrote:

its strange behaviour of js to evaluate literars like that

I wondered if it peculiar to your version of node.js. 🤷‍♂️

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haraka/Haraka/issues/2228#issuecomment-338009013, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobY3KLLdhSfEyN-TrD-7Ah6Jhr9ZGGks5st5_qgaJpZM4P_nfm .