haraka / Haraka

A fast, highly extensible, and event driven SMTP server
https://haraka.github.io
MIT License
5.08k stars 661 forks source link

auth_base : check_cram_md5_passwd argument fix #687

Closed xpepermint closed 10 years ago

xpepermint commented 10 years ago

Hey. Could we fix the format of the check_cram_md5_passwd function inside Haraka / plugins / auth / auth_base.js to have the same parameters as check_plain_passwd. I need the connection object inside this function to store user credentials as connection.notes. It would be easier to extend the auth.base.js module if the connection object would be available (also more logical).

exports.check_plain_passwd = function (connection, user, passwd, cb) {}
exports.check_cram_md5_passwd = function (connection, user, passwd, cb) {}
// original: exports.check_cram_md5_passwd = function (ticket, user, passwd, cb) {}

I ask before the PR ;).

msimerson commented 10 years ago

How does PR #722 look?