search

haraka / haraka-config

Haraka config file loader and parser
https://www.npmjs.com/package/haraka-config
MIT License
10 stars 13 forks source link

configfile: allow selecting slow watch behavior via env var #58

Closed celesteking closed 3 years ago

celesteking commented 4 years ago

override watch behavior by ENV vars

  1. HARAKA_CONFIG_CUSTOM_DIR sets custom config dir

  2. HARAKA_CONFIG_SLOWWATCH selects slow watch behavior

  3. A fix for the case when file is gone but config.get keeps returning pre-deletion data from cache.

celesteking commented 4 years ago

Let's discuss!

msimerson commented 4 years ago

I'm not a fan of the name "SLOWWATCH." What you're doing here isn't watching at all but polling.

celesteking commented 4 years ago

No shit captain. Have you read the docs? What about all these stuck tests btw?

celesteking commented 4 years ago

Anyway, is the varname the only thing that annoys you?

msimerson commented 4 years ago

No shit captain. Have you read the docs?

Yes.

I think the 'on' trigger needs to have pull_request added. I'm making that change in another PR.

msimerson commented 3 years ago

This PR seems abandoned. It doesn't pass lint tests and has no activity in half a year. If it were updated to pass the CI tests and replace the very long-winded explanation of motivation (you can document that here and link to it if you wish) with a succinct "this is how it works," paragraph, I'd be inclined to merge.

celesteking commented 3 years ago

It's the first time ever I see a patch being rejected on basis of containing too much documentation. Usually, it's the other way around. We won't get far with such attitude.

msimerson commented 3 years ago

It's the first time ever I see a patch being rejected on basis of containing too much documentation.

It's not. This PR hasn't been merged because it is failing lint tests. I told what you what I want to see before I merge it. There are others with merge access who may not mind wading through a wall of text to find the docs for the config options.

We won't get far with such attitude.

You have certainly demonstrated that. You asked for discussion but have been hostile towards it.

And curiously, you introduce env vars after calling them a security disaster in #39