haraka / haraka-eslint

eslint rules for Haraka projects
https://www.npmjs.com/package/@haraka/eslint-config
MIT License
2 stars 3 forks source link

An in-range update of eslint is breaking the build 🚨 #1

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.13.1 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.13.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:


Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/haraka/haraka-eslint/builds/190423419)
Release Notes v3.13.1
  • 3fc4e3f Fix: prefer-destructuring reporting compound assignments (fixes #7881) (#7882) (Teddy Katz)
  • f90462e Fix: no-extra-label autofix should not remove labels used elsewhere (#7885) (Teddy Katz)
Commits

The new version differs by 4 commits .

  • 7f8393c 3.13.1
  • 91883bf Build: package.json and changelog update for 3.13.1
  • 3fc4e3f Fix: prefer-destructuring reporting compound assignments (fixes #7881) (#7882)
  • f90462e Fix: no-extra-label autofix should not remove labels used elsewhere (#7885)

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.13.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

msimerson commented 7 years ago

Fixed (by adding a travis config)