search

haraka / haraka-eslint

eslint rules for Haraka projects
https://www.npmjs.com/package/@haraka/eslint-config
MIT License
2 stars 3 forks source link

SublimeLint breaks if you don't use full path #4

Closed baudehlo closed 7 years ago

msimerson commented 7 years ago

Interesting, SublimeLint works fine for me with the relative path.

baudehlo commented 7 years ago

It breaks (or broke) once you look at JS files in sub-folders - e.g. for outbound split.

On Mon, Mar 20, 2017 at 10:52 AM, Matt Simerson notifications@github.com wrote:

Merged #4 https://github.com/haraka/haraka-eslint/pull/4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haraka/haraka-eslint/pull/4#event-1006833237, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobY4MYpEig5qMqSrz677rTOGdkwzEdks5rnpLJgaJpZM4Mhmex .

msimerson commented 7 years ago

I've got half a mind to just inline that (now very tiny) bit of JSON. I just can't remember if there was any good reason to leave it outside of index.js or not.

baudehlo commented 7 years ago

I don't even know why it's loaded. It's not used.

On Mon, Mar 20, 2017 at 11:36 AM, Matt Simerson notifications@github.com wrote:

I've got half a mind to just inline that (now very tiny) bit of JSON. I just can't remember if there was any good reason to leave it outside of index.js or not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haraka/haraka-eslint/pull/4#issuecomment-287798052, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobY5WtS_nI7a4FZyE78GeRBCBE7owyks5rnp0PgaJpZM4Mhmex .

msimerson commented 7 years ago

It might be an anachronism from when all the rules were in that file. That line was probably there to make sure that the JSON file parsed correctly.

Wesitos commented 7 years ago

That line throws an exception when eslint is executed from a subdirectory (that's what flycheck does in emacs). Wouldn't it be better if we remove it?