search

haraka / haraka-net-utils

haraka network utilities
https://www.npmjs.com/package/haraka-net-utils
MIT License
2 stars 13 forks source link

skip loading expired x509 (TLS) certs #11

Closed msimerson closed 7 years ago

msimerson commented 7 years ago
codecov-io commented 7 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.19%. The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   81.54%   81.74%   +0.19%     
==========================================
  Files           1        1              
  Lines         233      241       +8     
  Branches       66       68       +2     
==========================================
+ Hits          190      197       +7     
- Misses         43       44       +1
Impacted Files Coverage Δ
index.js 81.74% <87.5%> (+0.19%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d93612a...5b72e2c. Read the comment docs.

baudehlo commented 7 years ago

For expired certs, could we do something nice like mailing the administrator?

On Fri, Mar 10, 2017 at 1:53 AM, Matt Simerson notifications@github.com wrote:

Merged #11 https://github.com/haraka/haraka-net-utils/pull/11.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haraka/haraka-net-utils/pull/11#event-994422995, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobYz-R2QcnwxpiHOCuoqEA2IX2NSf7ks5rkPN5gaJpZM4MZCQK .

msimerson commented 7 years ago

For expired certs, could we do something nice like mailing the administrator?

We do have nodemailer as a dev dependency but we don't know the email address of the admin and we surely don't have a way to assure we can get an email to their inbox. I'd much prefer to have a Haraka admin panel (HTTPS) that we can push alerts like that up to, where they can be dealt with.