Closed msimerson closed 7 years ago
Merging #13 into master will increase coverage by
0.04%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 88.21% 88.25% +0.04%
==========================================
Files 1 1
Lines 246 281 +35
Branches 71 84 +13
==========================================
+ Hits 217 248 +31
- Misses 29 33 +4
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 88.25% <88.88%> (+0.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e79fb8...501d8ba. Read the comment docs.
Right idea, wrong place to put the code. A soon-to-land PR moves the TLS config stuff into the one place it can be used everywhere: tls_socket.js
. No more of server.js
and tls_socket.js
reaching back into plugins/tls.js
to see how it worked out.
WIP, not ready to merge. Yet.