search

haraka / haraka-net-utils

haraka network utilities
https://www.npmjs.com/package/haraka-net-utils
MIT License
2 stars 13 forks source link

1.0.13 breaks current stable Haraka (2.8.16) #33

Closed smfreegard closed 6 years ago

smfreegard commented 6 years ago

Reported by EyePulp on IRC:

2018-01-25T21:34:36.566Z :: [CRIT] [-] [core] TypeError: net_utils.tls_ini_section_with_defaults is not a function 2018-01-25T21:34:36.567Z :: [CRIT] [-] [core] at Object.exports.get_tls_options (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/outbound/tls.js:10:35) 2018-01-25T21:34:36.568Z :: [CRIT] [-] [core] at pluggableStream. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/outbound/hmail.js:774:51) 2018-01-25T21:34:36.569Z :: [CRIT] [-] [core] at emitOne (events.js:96:13) 2018-01-25T21:34:36.572Z :: [CRIT] [-] [core] at pluggableStream.emit (events.js:188:7) 2018-01-25T21:34:36.572Z :: [CRIT] [-] [core] at pluggableStream.socket.process_data (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/line_socket.js:24:20) 2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at pluggableStream. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/line_socket.js:35:48) 2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at emitOne (events.js:96:13) 2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at pluggableStream.emit (events.js:188:7) 2018-01-25T21:34:36.574Z :: [CRIT] [-] [core] at Socket. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/tls_socket.js:57:14) 2018-01-25T21:34:36.575Z :: [CRIT] [-] [core] at emitOne (events.js:96:13)

Because Haraka's package.json contains:

"dependencies": { "haraka-net-utils" : ">=1.0.10", },

And https://github.com/haraka/haraka-net-utils/commit/e1c8e8bd68be092638f19102fd1bc94554b6d426 breaks it.

Maybe we should pin versions for release in future to prevent things like this from happening?

Cc: @baudehlo

baudehlo commented 6 years ago

By semver rules that change should never have gone out.

smfreegard commented 6 years ago

Typo on my part.... it's late here. 1.0.13 not 10.0.13

smfreegard commented 6 years ago

I've just had another person on IRC with the same issue. Fix is: cd /path/to/lib/node_modules/Haraka && npm install haraka-net-utils@1.0.10

msimerson commented 6 years ago

Dang, it's been so long since a release... I should have browsed back versions of Haraka instead of going from memory. I thought that wasn't a required function. I will:

smfreegard commented 6 years ago

Thanks - it happens - the dependencies have become quite complicated.