haraka / haraka-net-utils

haraka network utilities

https://www.npmjs.com/package/haraka-net-utils

MIT License

2 stars 13 forks source link

stop is_private_ip from checking if the IP is bound to a local network interface #42

Closed baudehlo closed 5 years ago

baudehlo commented 5 years ago

Fixes #41

codecov[bot] commented 5 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files           1        1           
  Lines         202      202           
  Branches       59       59           
=======================================
  Hits          167      167           
  Misses         35       35

Impacted Files	Coverage Δ
index.js	`82.67% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bab052...646ca4e. Read the comment docs.

baudehlo commented 5 years ago

@msimerson due to this bug we should probably delete 1.1.3 from npm. Thoughts?

msimerson commented 5 years ago

Also, we can't delete from npm. IIRC, there is an "unpublish" feature or something like that.

msimerson commented 5 years ago

$ npm publish
npm notice 
npm notice 📦  haraka-net-utils@1.1.4
npm notice === Tarball Contents === 
npm notice 1.1kB  package.json                           
npm notice 137B   .codeclimate.yml                       
npm notice 212B   .eslintrc.json                         
npm notice 238B   .travis.yml                            
npm notice 395B   appveyor.yml                           
npm notice 1.6kB  Changes.md                             
npm notice 13.4kB index.js                               
npm notice 1.1kB  LICENSE                                
npm notice 2.9kB  README.md                              
npm notice 490B   run_tests                              
npm notice 424B   test/config/dhparams.pem               
npm notice 14B    test/config/me                         
npm notice 1.2kB  test/config/tls_cert.pem               
npm notice 1.7kB  test/config/tls_key.pem                
npm notice 900B   test/config/tls.ini                    
npm notice 3.1kB  test/config/tls/haraka.local.pem       
npm notice 3.1kB  test/config/tls/haraka2.local.pem      
npm notice 7.1kB  test/config/tls/mail.theartfarm.com.pem
npm notice 36.8kB test/net_utils.js                      
npm notice === Tarball Details === 
npm notice name:          haraka-net-utils                        
npm notice version:       1.1.4                                   
npm notice package size:  24.5 kB                                 
npm notice unpacked size: 75.8 kB                                 
npm notice shasum:        8b42c72f6875c25f3fde38c6775805f960f85be5
npm notice integrity:     sha512-/wJ5kRJJHqyAE[...]KR1R+wdXuiYlg==
npm notice total files:   19                                      
npm notice 
+ haraka-net-utils@1.1.4

msimerson commented 5 years ago

$ npm unpublish haraka-net-utils@1.1.3
-haraka-net-utils@1.1.3