haraka / haraka-plugin-rspamd

Rspamd plugin for Haraka
https://www.npmjs.com/package/haraka-plugin-rspamd
MIT License
15 stars 14 forks source link

CRIT Invalid character in header content ["From"] #28

Closed DoobleD closed 1 year ago

DoobleD commented 2 years ago

system info

Please report your OS, Node version, and Haraka version by running this shell script on your Haraka server and replacing this section with the output.

Haraka Haraka.js — Version: 2.8.28
Node v14.19.3
OS Linux mail.postale.io 5.11.0-1028-aws #31~20.04.1-Ubuntu SMP Fri Jan 14 14:37:50 UTC 2022 x86_64 GNU/Linux
openssl OpenSSL 1.1.1n 15 Mar 2022

Expected behavior

No CRIT error even when a header field is malformed.

Observed behavior

It seems that the plugin fails with a CRIT error whenever the From header field contains an invalid character. Very rare occurrence though, as this is pretty uncommon.

[CRIT] [B3DF23E0-4B6C-4DFC-82FD-8196EF016B95.1] [core] Plugin rspamd failed: TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["From"]

Steps to reproduce

Send an email with an invalid character in the From header. But to be honest I haven't been able to find what's considered invalid. Suggestions are welcome!