Misc fixes - Githubissues

haraka / haraka-plugin-spf

SPF plugin for Haraka

https://www.npmjs.com/package/haraka-plugin-spf

MIT License

2 stars 5 forks source link

Misc fixes #15

Closed smfreegard closed 1 year ago

smfreegard commented 1 year ago

Changes proposed in this pull request:

Fixes bug when array is returned on longer SPF records, for example:

found SPF record for domain facebookmail.com: v=spf1 ip4:66.220.144.128/25 ip4:66.220.155.0/24 ip4:66.220.157.0/25 ip4:69.63.178.128/25 ip4:69.63.181.0/24 ip4:69.63.184.0/25, ip4:69.171.232.0/24 ip4:69.171.244.0/23 -all
syntax error: ip4:69.63.184.0/25,

spf command-line tool was still using callbacks, so the result was not being returned correctly
silence skipping unknown modifier: v error by adding modifier function

Checklist:

[ ] docs updated
[x] tests updated
[ ] Changes.md updated

smfreegard commented 1 year ago

Sure - good point, updated!