search

haraka / haraka-plugin-syslog

Haraka plugin that logs via syslog
MIT License
3 stars 4 forks source link

The constant is constants.ok not constants.OK #4

Closed baudehlo closed 7 years ago

msimerson commented 7 years ago

Actually, as of version 1.0.2 the constants are exported in lower (legacy) and uppercase formats. That matches what the docs imply and it's what we SHOULD be using, because programmers expect constants to be in all caps. The only change needed here is to require haraka-constants >= 1.0.2.

baudehlo commented 7 years ago

Ok happy to change the PR to do that.

On May 22, 2017, at 12:39 AM, Matt Simerson notifications@github.com wrote:

Actually, as of version 1.0.2 the constants are exported in lower (legacy) and uppercase formats. That matches what the docs imply and it's what we SHOULD be using, because programmers expect constants to be in all caps. The only change needed here is to require haraka-constants >= 1.0.2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

msimerson commented 7 years ago

Awesome. Feel free to also bump the version number, update Changes.md and publish to NPM after the CI tests pass.

baudehlo commented 7 years ago

I dropped the ball on this one. Updated now.

baudehlo commented 7 years ago

Merged and published.