haraka / haraka-utils

Haraka's general purpose utilities
https://www.npmjs.com/package/haraka-utils
MIT License
2 stars 4 forks source link

change names of 1024 base units to match IEC 80000-13:2008 standard #12

Closed ghost closed 7 years ago

ghost commented 7 years ago

units with 1024 base should use binary prefix https://wikipedia.org/wiki/Binary_prefix

codecov[bot] commented 7 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files           1        1           
  Lines         168      168           
  Branches       34       34           
=======================================
  Hits          153      153           
  Misses         15       15
Impacted Files Coverage Δ
index.js 91.07% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd8edf2...4dee733. Read the comment docs.

smfreegard commented 7 years ago

@msimerson - I agree with you. I really don't like this change at all.

ghost commented 7 years ago

Should not this go with standards as everything else? You can not pick only standards you like, that is nonsense.

Edit: I hope this does not come across as rude. What I want to say is that going against standards is never a good choice. And you are right that fix was not a proper word choice.

msimerson commented 7 years ago

Actually, I’d call that optimism. Not every standard ends up getting adoption and some standards end up falling by the wayside. However it appears this one has sufficient traction, the problem is pernicious enough, and that adopting it is the right thing

KingNoosh commented 7 years ago

We get taught the new standard in schools. +1

On 2 Oct 2017 15:53, "Matt Simerson" notifications@github.com wrote:

Actually, I’d call that optimism. Not every standard ends up getting adoption and some standards end up falling by the wayside. However it appears this one has sufficient traction, the problem is pernicious enough, and that adopting it is the right thing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haraka/haraka-utils/pull/12#issuecomment-333558765, or mute the thread https://github.com/notifications/unsubscribe-auth/AJbg3oRuoi9JFiqWs_Grs8BeePx66Se7ks5soPjUgaJpZM4PqdCc .

ghost commented 7 years ago

@msimerson what do you think about this title to this issue?

msimerson commented 7 years ago

The thread reminds me of that old saying, “the reason we have so many standards is so that we can pick the ones that we like. “

msimerson commented 7 years ago

what do you think about this title to this issue?

It has a typo. Don’t try and please me, I’ve got my curmudgeon hat on this morning. :-)

ghost commented 7 years ago

I am afraid I am a bit too late on correcting that one. :cry: