search

haraka / node-address-rfc2821

RFC2821 Email Address parser (from Haraka)
https://www.npmjs.com/package/address-rfc2821
13 stars 6 forks source link

Fix unicode regexs parts to not escape latin chars #15

Closed analogic closed 6 years ago

analogic commented 6 years ago

I have hit IDN problem when username contains unicode chars - all chars < \u0100 are escaped like this:

přílišžluťoučkýkůň@přílišžluťoučkýkůň.cz -> "př\ílišžluťoučkýkůň"@přílišžluťoučkýkůň.cz

codecov[bot] commented 6 years ago

Codecov Report

Merging #15 into master will increase coverage by 1.12%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   82.02%   83.14%   +1.12%     
==========================================
  Files           2        2              
  Lines          89       89              
  Branches       18       18              
==========================================
+ Hits           73       74       +1     
+ Misses         16       15       -1
Impacted Files Coverage Δ
index.js 82.95% <85.71%> (+1.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cbdc96...a769fe6. Read the comment docs.

analogic commented 6 years ago

done!

msimerson commented 6 years ago 
$ npm publish
+ address-rfc2821@1.1.3
baudehlo commented 6 years ago

Thanks Matt!

On Fri, May 11, 2018 at 3:25 PM, Matt Simerson notifications@github.com wrote:

$ npm publish

  • address-rfc2821@1.1.3

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/haraka/node-address-rfc2821/pull/15#issuecomment-388462330, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobYy4GaTexlhAJdp1cKEZW3WMWCRxLks5txeWmgaJpZM4T7aKq .