Null to empty string - Githubissues

haraka / node-address-rfc2821

RFC2821 Email Address parser (from Haraka)

https://www.npmjs.com/package/address-rfc2821

13 stars 6 forks source link

Null to empty string #3

Closed msimerson closed 7 years ago

msimerson commented 7 years ago

replace null values with empty strings
only test on node.js 4 & 6
update codecov syntax

Fixes haraka/Haraka#1737

codecov-io commented 7 years ago

Current coverage is 84.81% (diff: 100%)

No coverage report found for master at db22d72.

Powered by Codecov. Last update db22d72...99a67dd

msimerson commented 7 years ago

Sure, but format() is unaffected by this change. I added two test, one for format() and another that validates that hostnames are (by default) already being lower cased.

smfreegard commented 7 years ago

Thanks - LGTM.

baudehlo commented 7 years ago

format() isn't untouched because it uses the truthiness of .host - that's all I'm concerned about.

On Thu, Dec 8, 2016 at 7:22 PM, Steve Freegard notifications@github.com wrote:

Thanks - LGTM.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/haraka/node-address-rfc2821/pull/3#issuecomment-265896685, or mute the thread https://github.com/notifications/unsubscribe-auth/AAobYzmnmip7kYVeX1SIaCcMe1XwDBcXks5rGJ84gaJpZM4LIZfB .

msimerson commented 7 years ago

$ npm publish
+ address-rfc2821@1.0.1