search

haraka / node-address-rfc2822

Parser for RFC2822 (Header) format email addresses
https://www.npmjs.com/package/address-rfc2822
53 stars 16 forks source link

Fix possible catastrophic backtracking bug #28

Closed baudehlo closed 6 years ago

baudehlo commented 6 years ago

It makes the regexp not quite the same, but the tests still pass so I'm happy enough with it.

baudehlo commented 6 years ago

@msimerson not sure if you got the email about this, but hopefully this covers the bug.

codecov[bot] commented 6 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files           1        1           
  Lines         115      115           
  Branches       29       29           
=======================================
  Hits          102      102           
  Misses         13       13
Impacted Files Coverage Δ
index.js 88.69% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c05298a...bd104ad. Read the comment docs.

smfreegard commented 6 years ago

LGTM - much better to trim it before the regexp.

baudehlo commented 6 years ago

Published.

matt@calhorn ~/Development/node-address-rfc2822$ npm publish
+ address-rfc2822@2.0.2