haraka / test-fixtures

Fixtures for testing Haraka and plugins

https://www.npmjs.com/package/haraka-test-fixtures

MIT License

2 stars 6 forks source link

Add missing server property and allow setImmediate in pluigns #20

Closed smfreegard closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.1%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #20     +/-   ##
=========================================
+ Coverage   55.55%   55.66%   +0.1%     
=========================================
  Files           9        9             
  Lines         423      424      +1     
  Branches       85       85             
=========================================
+ Hits          235      236      +1     
  Misses        188      188

Impacted Files	Coverage Δ
lib/plugin.js	`83.87% <100%> (+0.17%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ad2811...c5a5ebe. Read the comment docs.

msimerson commented 7 years ago

LGTM. Just update Changes.md, merge & publish.

smfreegard commented 7 years ago

Ta - doesn't look like I've got permissions to npm publish though. Username is 'smfreegard'.

msimerson commented 7 years ago

When I try to add you to the module as a collaborator, npm says, user not found: smfreegard

smfreegard commented 7 years ago

Do you need to add me to the Haraka organization first? - the user definitely exists:

smf@i7desktop:~/git/haraka-test-fixtures$ npm login
Username: smfreegard
Password: 
Email: (this IS public) steve@freegard.name
Logged in as smfreegard on https://registry.npmjs.org/.

msimerson commented 7 years ago

Weird. I've just been able to add you to the Haraka collabs on npm (which I wasn't able to do before), but when I try to do the same on haraka-plugin-fixtures (where the same 3 collabs (haraka, myself, and baudehlo exist) I get that user not found error.

smfreegard commented 7 years ago

Ok - can you npm publish this and it should cure the test failures on the other PRs I've done. I've no idea what the problem with npm is.

msimerson commented 7 years ago

$ npm publish
+ haraka-test-fixtures@1.0.18

I still don't know what's up with npm. I've been able to add your profile to a couple other @haraka modules that I couldn't before. I'll try again in the future and maybe whatever this issue is will have cleared.