search

haraldh / rust_uds_windows

Unix Domain Sockets for Windows!
MIT License
29 stars 6 forks source link

New async io interfaces #9

Closed TTWNO closed 11 months ago

TTWNO commented 11 months ago

A fix-up of #8

I understand you requested safety comments, however, it appears that safety comments are being generated for parts of the code unchanged by this PR.

haraldh commented 11 months ago

cargo fmt check failed

haraldh commented 11 months ago

I requested source code comments stating, why the unsafe {} sections are actually safe. Like:

  // SAFETY: the following unsafe section is safe, because ....
haraldh commented 11 months ago

See also https://std-dev-guide.rust-lang.org/policy/safety-comments.html#inside-safe-elements

TTWNO commented 11 months ago

I requested source code comments stating, why the unsafe {} sections are actually safe.

I understand now.

TTWNO commented 11 months ago

Just checking if there's anything else I need to do to get this merged? Happy to get started on it ASAP :)

haraldh commented 11 months ago

Maybe rebase on the current master and squash some commits

TTWNO commented 11 months ago

Done!

haraldh commented 11 months ago

Thanks!

haraldh commented 10 months ago

released 1.1.0