Closed don-vip closed 1 month ago
Thanks for providing this! 👍🏻
So, no special handling of these complex types are needed? 😮
I will add a full review as soon as possible, I'm back in the office from Monday. But looks like this can be safely merged.
Can you send the sample file? Maybe we can trim it a bit in a hex editor, if it's uncompressed or tiled/striped. But I agree, 25 MB for testing this is a but much.
UPDATE: I see you have linked the file in your original description, never mind. 😀
Thanks for the review! Honestly I don't know if more changes are needed, those simple changes were enough for me to read the sample file.
I merged the PR. Thanks again!
Fixes #884
I didn't add tests in the commit (although I wrote one) because the smallest sample file I could find is 25 Mb... Let me know if I should add it anyway: