search

haraldk / TwelveMonkeys

TwelveMonkeys ImageIO: Additional plug-ins and extensions for Java's ImageIO
https://haraldk.github.io/TwelveMonkeys/
BSD 3-Clause "New" or "Revised" License
1.91k stars 315 forks source link

Fix subsampling issues for BMP plugin #289

Open haraldk opened 8 years ago

haraldk commented 8 years ago

See overrides of ImageReaderAbstractTest.testReadWithSubsampleParamPixels with @Ignore annotations.

There are also issues left with subsampling sub-component (ie. 1, 2, 4 bits/pixel, packed ushort 565/4444 etc) types in the TIFFImageReader.

JPEGLossless currently does not support subsampling.

More rigorous testing should probably be applied to other formats as well. :-)

adriannuix commented 7 years ago

Hi Harald,

Do we have any updates on this? A customer is asking...

Thank you Adrian

haraldk commented 7 years ago

Hi Adrian,

The TIFF subsampling is in progress. BMP no, JPEG lossless no (though I obviously want to fix these too, as soon as possible). What is your customer's requirement?

I wish I could, but I can't promise any dates as long as this is a spare time project that I don't make any money from. Feeding the family must come first. :-)

But as mentioned above, there are test cases for this, that you could enable and fix, if you are in a hurry.

Best regards,

-- Harald K

adriannuix commented 7 years ago

Hi Harald,

I understand and sympathize with that. We have some 2 types of rendering for some image files like tiff. One large that works and one small that does not work on Tiffs because of the issue. We'll probably release in a week or so as we are not on fixed schedule. It's not a do or die but it's an outstanding bug that's been there for a while.

Cheers, Adrian

On Fri, Jul 21, 2017 at 7:52 PM, Harald Kuhr notifications@github.com wrote:

Hi Adrian,

The TIFF subsampling is in progress. BMP no, JPEG lossless no. What is your customer's requirement?

I wish I could, but I can't promise any dates as long as this is a spare time project that I don't make any money from. Feeding the family must come first. :-)

But as mentioned above, there are test cases for this, that you could enable and fix, if you are in a hurry.

Best regards,

-- Harald K

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/haraldk/TwelveMonkeys/issues/289#issuecomment-316958791, or mute the thread https://github.com/notifications/unsubscribe-auth/AZpYmisYKVH87uD5QET9NC99hJvVDqwMks5sQHTUgaJpZM4Knk9N .

--

Adrian Filip adrian.filip@nuix.com | http://www.nuix.com

Ph: + 61 2 9280 0699 | M: +61 469 931 383 <%2B61%202%209212%206902>

Level 27, 1 Market St, Sydney, NSW, 2000, Australia

Skype: AdrianNuix | Twitter: twitter.com/nuix http://www.twitter.com/nuix

haraldk commented 6 years ago

Seems most of this is fixed for the TIFFImageReader. Postponing the remainder for the BMP format to later version.