search

haraldsk / puppet-module-nfs

Deprecated. Use echocat-nfs instead.
https://github.com/echocat/puppet-nfs
13 stars 99 forks source link

Module doesn't work with Amazon linux #27

Open mattboston opened 10 years ago

mattboston commented 10 years ago

Amazon Linux is a derivative of RHEL6/CentOS6 and functions exactly the same, but for some reason your module fails.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: OS: Amazon not supported at /etc/puppet/modules/nfs/manifests/params.pp:21 on node ops-backup Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run

If I update the Params.pp file to add 'amazon' to the RHEL definition, then I get the following error.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: No matching value for selector param 'undef' at /etc/puppet/modules/nfs/manifests/client/redhat/service.pp:17 on node ops-backup Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run

Here's the relevant facter info from an Amazon Linux instance

facter osfamily operatingsystem osmajor

operatingsystem => Amazon osfamily => RedHat osmajor =>

haraldsk commented 10 years ago

Hey.

Look in: manifests/client/redhat/params.pp

That code need to be made aware aware that it's running on Amazon and set osmajor = 6.

If you make a pull request. Make sure to add in tests for Amazon aswell and i'll merge it. Else it will have to wait untill i have time to it myself.