harbassan / spicetify-apps

A collection of spicetify custom apps to improve your spotify experience.
396 stars 24 forks source link

[Both] Topbar buttons appear enlarged #86

Closed TecEash1 closed 5 months ago

TecEash1 commented 5 months ago

After updating spicetify it appears that there are a few bugs.

image image
Maskowh commented 5 months ago

This seems to also break the arrows in the standard playlists list in the bottom left corner. Those arrows look fine when I remove both stats and library customapps.

image

3131694874 commented 5 months ago

image error

harbassan commented 5 months ago

This will be fixed in probably the next spicetify update. Just have to wait a bit for that.

pikachub2005 commented 5 months ago

It was not fixed 😔 image Screenshot 2024-04-25 025222

TecEash1 commented 5 months ago

Maybe in the next update?, Btw the same issue occurs with stats.

rxri commented 5 months ago

This will be fixed in probably the next spicetify update. Just have to wait a bit for that.

@harbassan What am I supposed to fix? Your assignment of iconSize to IconComponent is wrong. You're supposed to pass the number, not string. We switched the IconComponent component few updates ago, however even if it worked before, it wasn't the right way to assign the iconSize. We do not pass string to IconComponent in wrapper either.

function AddIcon(): React.ReactElement<SVGElement> {
    return (
        <Spicetify.ReactComponent.IconComponent
            semanticColor="textSubdued"
            dangerouslySetInnerHTML={{
                __html:
                    '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><path d="M15.25 8a.75.75 0 0 1-.75.75H8.75v5.75a.75.75 0 0 1-1.5 0V8.75H1.5a.75.75 0 0 1 0-1.5h5.75V1.5a.75.75 0 0 1 1.5 0v5.75h5.75a.75.75 0 0 1 .75.75z"></path></svg>',
            }}
-           iconSize="16"
+           iconSize={16}
        />
    );
}

That should be done in all files that are using IconComponent

harbassan commented 5 months ago

Sweet, i kind of just assumed that it was meant to be that way, ill probably need to change it in a few diff places then because i've probably done this in a lot of different components lol. Thanks tho.